Skip to content

[Dashboard] Feature: Adds analytics to in-app-wallets page (#5186) #5227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2024
Merged

[Dashboard] Feature: Adds analytics to in-app-wallets page (#5186) #5227

merged 1 commit into from
Oct 30, 2024

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 30, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR primarily focuses on enhancing the in-app wallet features by introducing new analytics capabilities, updating constants, and refining the layout and structure of various components related to in-app wallets.

Detailed summary

  • Added InAppWalletStats interface for analytics.
  • Introduced TRACKING_CATEGORY constants for embedded wallets and team in-app wallets.
  • Updated pages to utilize new analytics features and constants.
  • Removed AnalyticsCallout from layouts.
  • Improved component structure and layout for better user experience.
  • Enhanced InAppWalletAnalytics and InAppWalletUsersChartCard for better data visualization.
  • Refactored routing logic to redirect to analytics by default.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl @joaquim-verges
[Dashboard] Feature: Adds analytics to in-app-wallets page (#5186)
a3d1383 
<img width="1106" alt="Screenshot 2024-10-25 at 4 02 59 PM" src="https://github.com/user-attachments/assets/8b559170-2d5e-4810-8a29-55f155448e40">

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the in-app wallets feature by adding tracking capabilities, restructuring components, and improving analytics. It introduces new interfaces, updates existing components, and removes unnecessary elements to streamline functionality and improve user experience.

### Detailed summary
- Added `InAppWalletStats` interface.
- Introduced `TRACKING_CATEGORY` constants for analytics.
- Updated components to utilize new tracking categories.
- Removed `AnalyticsCallout` from layout.
- Replaced `Separator` with `<div className="h-5" />` for spacing.
- Enhanced analytics pages to fetch and display wallet usage data.
- Implemented new routing for in-app wallet analytics.
- Updated `InAppWalletUsersChartCard` for better data visualization.
- Improved the structure of the `Tabs` component for navigation.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2024

⚠️ No Changeset found

Latest commit: a3d1383

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 0:52am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 30, 2024 0:52am
thirdweb_playground ⬜️ Skipped (Inspect) Oct 30, 2024 0:52am
wallet-ui ⬜️ Skipped (Inspect) Oct 30, 2024 0:52am

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 30, 2024 00:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 30, 2024 00:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 30, 2024 00:42 Inactive
@joaquim-verges joaquim-verges marked this pull request as ready for review October 30, 2024 00:42
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 30, 2024
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Oct 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (043ee92) to head (a3d1383).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5227   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1067     1067           
  Lines       55341    55341           
  Branches     3973     3973           
=======================================
  Hits        25068    25068           
  Misses      29581    29581           
  Partials      692      692
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 043ee92
packages 40.30% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 4.5 s (+53.51% 🔺) 5.4 s
thirdweb (cjs) 102.91 KB (0%) 2.1 s (0%) 7 s (-18.23% 🔽) 9.1 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 143 ms (-57.35% 🔽) 240 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 97 ms (+66.18% 🔺) 107 ms
thirdweb/react (minimal + tree-shaking) 17.38 KB (0%) 348 ms (0%) 508 ms (-30.94% 🔽) 856 ms

@joaquim-verges joaquim-verges merged commit 6e87a86 into main Oct 30, 2024
31 checks passed
@joaquim-verges joaquim-verges deleted the joaquim/in-app-stats branch October 30, 2024 01:02
joaquim-verges added a commit that referenced this pull request Oct 30, 2024
@joaquim-verges
Revert "[Dashboard] Feature: Adds analytics to in-app-wallets page (#…
e739552 
…5186) (#5227)"

This reverts commit 6e87a86.
joaquim-verges added a commit that referenced this pull request Oct 30, 2024
@joaquim-verges @gregfromstl
[Dashboard] Feature: Adds analytics to in-app-wallets page (#5186) (#…
e3dbcf2 
…5227)

Co-authored-by: gregfromstl <[email protected]>
joaquim-verges added a commit that referenced this pull request Oct 30, 2024
@joaquim-verges @gregfromstl
[Dashboard] Feature: Adds analytics to in-app-wallets page (#5186) (#…
8df3f12 
…5227)

Co-authored-by: gregfromstl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls Awaiting requested review from jnsdls

@MananTank MananTank Awaiting requested review from MananTank

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquim-verges @gregfromstl